Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): default sensible flags for update and export #3342

Merged
merged 7 commits into from Mar 16, 2023

Conversation

m-alisafaee
Copy link
Contributor

@m-alisafaee m-alisafaee commented Mar 2, 2023

Fixes #3276

TODO

  • Once review is done, move _update from renku.command.update to renku.core.workflow.update.

@m-alisafaee m-alisafaee force-pushed the 3276-default-flags branch 3 times, most recently from d094159 to ca9046b Compare March 3, 2023 09:11
@coveralls
Copy link
Collaborator

coveralls commented Mar 3, 2023

Pull Request Test Coverage Report for Build 4436198858

  • 35 of 36 (97.22%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+86.8%) to 86.819%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/workflow/update.py 27 28 96.43%
Totals Coverage Status
Change from base Build 4435301967: 86.8%
Covered Lines: 25615
Relevant Lines: 29504

💛 - Coveralls

@m-alisafaee m-alisafaee closed this Mar 3, 2023
@m-alisafaee m-alisafaee reopened this Mar 3, 2023
@m-alisafaee m-alisafaee closed this Mar 3, 2023
@m-alisafaee m-alisafaee reopened this Mar 3, 2023
@m-alisafaee m-alisafaee marked this pull request as ready for review March 3, 2023 17:21
@m-alisafaee m-alisafaee requested a review from a team as a code owner March 3, 2023 17:21
renku/ui/cli/update.py Outdated Show resolved Hide resolved
@m-alisafaee m-alisafaee enabled auto-merge (squash) March 15, 2023 16:31
@m-alisafaee m-alisafaee enabled auto-merge (squash) March 16, 2023 10:49
@m-alisafaee m-alisafaee merged commit 8bef1b9 into develop Mar 16, 2023
27 of 28 checks passed
@m-alisafaee m-alisafaee deleted the 3276-default-flags branch March 16, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: renku update should default to --all with a warning/prompt
4 participants