New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that template migration of dockerfile works correctly #3346

Closed

Panaetius opened this issue Mar 3, 2023 · 0 comments · Fixed by #3351

Labels

Member

Panaetius commented Mar 3, 2023

There are issues with old projects and the new SSH feature, because the Dockerfile doesn't get update from the template.

What I think happens is

user migrates the project
Dockerfile is updated from template
Renku version is set in template --> checksum changes
some time later, user migrates a gain
Template update sees that Dockerfile was changed since the last update from template, so since there's "local" modifications, Dockerfile isn't updated.

We should fix this to handle the checksums for the Dockerfile differently

Panaetius added kind/bug status/triage labels

m-alisafaee mentioned this issue

fix(core): update template checksum when updating Dockerfile #3351

Merged

Panaetius removed the status/triage label

m-alisafaee closed this as completed in #3351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment