Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(service): fix error message for invalid templates #3349

Merged
merged 4 commits into from Mar 14, 2023
Merged

fix(service): fix error message for invalid templates #3349

merged 4 commits into from Mar 14, 2023

Conversation

Panaetius
Copy link
Member

close #3325

@Panaetius Panaetius requested a review from a team as a code owner March 6, 2023 10:27
@coveralls
Copy link
Collaborator

coveralls commented Mar 6, 2023 •
edited

Pull Request Test Coverage Report for Build 4406898513

  • 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+86.1%) to 86.105%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/controllers/templates_create_project.py 2 4 50.0%
Totals Coverage Status
Change from base Build 4406264637: 86.1%
Covered Lines: 25456
Relevant Lines: 29564
💛 - Coveralls

@Panaetius Panaetius merged commit 6798b1a into develop Mar 14, 2023
28 of 30 checks passed
@Panaetius Panaetius deleted the bugfix/3325-service-invalid-template-error branch March 14, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project creation returns wrong error message if template is invalid
3 participants
@Panaetius @coveralls @olevski