Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): allow setting default CLI version for project creation #3415

Merged
merged 7 commits into from Apr 27, 2023
Merged

feat(service): allow setting default CLI version for project creation #3415

merged 7 commits into from Apr 27, 2023

Conversation

Panaetius
Copy link
Member

closes #3401

@Panaetius Panaetius requested a review from a team as a code owner April 24, 2023 09:47
@Panaetius Panaetius mentioned this pull request Apr 24, 2023
Merged
@coveralls
Copy link
Collaborator

coveralls commented Apr 24, 2023 •
edited

Pull Request Test Coverage Report for Build 4817067557

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.02%) to 85.317%
Files with Coverage Reduction New Missed Lines %
renku/core/workflow/activity.py 1 93.93%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 68.59%
renku/command/rollback.py 2 78.7%
Totals Coverage Status
Change from base Build 4813754310: 0.02%
Covered Lines: 25543
Relevant Lines: 29939
💛 - Coveralls

@Panaetius Panaetius enabled auto-merge (squash) April 27, 2023 07:16
@Panaetius Panaetius merged commit 9f16b0a into develop Apr 27, 2023
28 checks passed
@Panaetius Panaetius deleted the 3401-core-svc-cli-version branch April 27, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevski olevski olevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

set core-service cli version for new projects manually
3 participants
@Panaetius @coveralls @olevski