Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): fix working on branches in the core-svc #3472

Merged
merged 5 commits into from May 26, 2023

Conversation

Panaetius
Copy link
Member

closes #3458

@Panaetius Panaetius requested a review from a team as a code owner May 22, 2023 13:56
@coveralls
Copy link
Collaborator

coveralls commented May 22, 2023

Pull Request Test Coverage Report for Build 5090884416

  • 10 of 26 (38.46%) changed or added relevant lines in 8 files are covered.
  • 1556 unchanged lines in 103 files lost coverage.
  • Overall coverage decreased (-5.2%) to 80.175%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/controllers/templates_read_manifest.py 0 1 0.0%
renku/ui/service/serializers/common.py 6 8 75.0%
renku/ui/service/gateways/gitlab_api_provider.py 0 3 0.0%
renku/ui/service/controllers/api/mixins.py 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
renku/command/schema/calamus.py 1 72.58%
renku/core/dataset/providers/external.py 1 79.1%
renku/core/dataset/providers/factory.py 1 80.26%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/util/urls.py 1 74.19%
renku/domain_model/provenance/agent.py 1 81.72%
renku/ui/cli/init.py 1 96.9%
renku/ui/service/entrypoint.py 1 80.65%
renku/ui/service/jobs/queues.py 1 92.59%
renku/ui/service/serializers/cache.py 1 93.84%
Totals Coverage Status
Change from base Build 5079704843: -5.2%
Covered Lines: 24140
Relevant Lines: 30109

💛 - Coveralls

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf! Please see my comment.

renku/ui/service/serializers/common.py Outdated Show resolved Hide resolved
renku/ui/service/controllers/api/mixins.py Outdated Show resolved Hide resolved
@Panaetius Panaetius merged commit 0eaf204 into develop May 26, 2023
27 of 28 checks passed
@Panaetius Panaetius deleted the fix-svc-branch-usage branch May 26, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Config API does not support the branch parameter
3 participants