Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix special paths in workflow files and bump toil/cwltool #3489

Merged
merged 4 commits into from Jun 1, 2023

Conversation

Panaetius
Copy link
Member

closes #3455

cwl-utils changed the logic for calculating relative paths of steps where without a file:// scheme it made all paths relative to the current working dir, which differs from the path the workflow file is at.

Workflows/renku status didn't work with filenames like test<>b&c\\d .csv, as git returned them quoted

@coveralls
Copy link
Collaborator

coveralls commented May 31, 2023

Pull Request Test Coverage Report for Build 5142089880

  • 10 of 12 (83.33%) changed or added relevant lines in 4 files are covered.
  • 23 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.09%) to 85.375%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/migration/m_0005__2_cwl.py 4 5 80.0%
renku/infrastructure/repository.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
renku/core/workflow/activity.py 1 93.93%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 68.91%
renku/ui/service/errors.py 1 82.54%
renku/infrastructure/repository.py 2 81.5%
renku/ui/service/views/error_handlers.py 2 87.07%
renku/core/util/git.py 5 85.07%
renku/core/migration/models/v9.py 10 80.31%
Totals Coverage Status
Change from base Build 5141817213: 0.09%
Covered Lines: 25826
Relevant Lines: 30250

💛 - Coveralls

olevski
olevski previously approved these changes Jun 1, 2023
@Panaetius Panaetius merged commit 28086cf into develop Jun 1, 2023
30 checks passed
@Panaetius Panaetius deleted the update-toil branch June 1, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bump cwltool and toil
3 participants