Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt dataset import to KG changes #3543

Closed
m-alisafaee opened this issue Jun 29, 2023 · 0 comments · Fixed by #3549
Closed

Adapt dataset import to KG changes #3543

m-alisafaee opened this issue Jun 29, 2023 · 0 comments · Fixed by #3549
Labels
dataset kind/enhancement

Comments

@m-alisafaee
Copy link
Contributor

KG changed the field name in their response to be schema:name (i.e. Dataset.title in CLI) instead of renku:slug (i.e. Dataset.name in CLI). They added a slug field for the latter.
We use name from the KG's response to fetch the dataset in the source project which would fail causing the dataset import to fail:

renku-python/renku/core/dataset/providers/renku.py

Line 487 in fab2b58

dataset = datasets_provenance.get_by_name(self._name)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dataset kind/enhancement
Projects
renku-python
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): adapt to changes in KG api for importing datasets SwissDataScienceCenter/renku-python
1 participant
@m-alisafaee