Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing non-branch ref to read-only core-svc endpoints #3579

Closed
Panaetius opened this issue Aug 8, 2023 · 0 comments · Fixed by #3608
Closed

allow passing non-branch ref to read-only core-svc endpoints #3579

Panaetius opened this issue Aug 8, 2023 · 0 comments · Fixed by #3608
Assignees

Comments

@Panaetius
Copy link
Member

For readonly endpoints like config.show, passing a commit sha or tag should be fine alongside a branch. This should not work for write endpoints, as writing on top of a tag or detached commit doesn't make sense.

The Ui needs this to get config values when launching sessions from a commit and some other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants