Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): return project version as int #3591

Merged
merged 3 commits into from Aug 21, 2023
Merged

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 15, 2023

/deploy #persist

closes #3569

@olevski olevski requested a review from a team as a code owner August 15, 2023 13:39
@olevski olevski marked this pull request as draft August 15, 2023 13:39
@olevski olevski temporarily deployed to renku-ci-rp-3591 August 15, 2023 13:39 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-3591.dev.renku.ch

@olevski
Copy link
Member Author

olevski commented Aug 15, 2023

If you visit: https://renku-ci-rp-3591.dev.renku.ch/api/renku/apiversion

The result has an integer instead of a float:

{"result":{"latest_version":"2.7.0.dev3+g12f73dd5","maximum_api_version":"2.1","minimum_api_version":"1.0","supported_project_version":10}}

@olevski olevski marked this pull request as ready for review August 15, 2023 14:13
@olevski olevski temporarily deployed to renku-ci-rp-3591 August 15, 2023 14:13 — with GitHub Actions Inactive
@coveralls
Copy link
Collaborator

coveralls commented Aug 15, 2023

Pull Request Test Coverage Report for Build 5931149270

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 85.731%

Files with Coverage Reduction New Missed Lines %
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 67.72%
Totals Coverage Status
Change from base Build 5900967698: 0.01%
Covered Lines: 25853
Relevant Lines: 30156

💛 - Coveralls

@olevski olevski enabled auto-merge (squash) August 21, 2023 20:29
@olevski olevski deployed to renku-ci-rp-3591 August 21, 2023 20:29 — with GitHub Actions Active
@olevski olevski merged commit 1ac3914 into develop Aug 21, 2023
25 of 27 checks passed
@olevski olevski deleted the fix-3569-api-version branch August 21, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fix /apiversion endpoint format and redirect in gateway
4 participants