Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): properly formatted dataset image IDs #3596

Merged
merged 5 commits into from Aug 22, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Aug 21, 2023

closes #3582

@olevski olevski requested a review from a team as a code owner August 21, 2023 20:14
@olevski olevski marked this pull request as draft August 21, 2023 20:14
@olevski olevski temporarily deployed to renku-ci-rp-3596 August 21, 2023 20:14 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-3596.dev.renku.ch

@olevski olevski force-pushed the fix-3582-renku-graph-export-with-zenodo-dataset branch from be56019 to 6d53ddf Compare August 21, 2023 20:23
@olevski olevski temporarily deployed to renku-ci-rp-3596 August 21, 2023 20:23 — with GitHub Actions Inactive
@coveralls
Copy link
Collaborator

coveralls commented Aug 21, 2023

Pull Request Test Coverage Report for Build 5941753853

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+1.1%) to 86.833%

Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/repository.py 1 88.46%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 67.72%
renku/ui/service/cache/models/job.py 1 97.44%
renku/command/rollback.py 2 78.7%
renku/core/util/os.py 2 88.38%
renku/core/workflow/activity.py 2 93.61%
renku/core/dataset/dataset.py 3 84.99%
Totals Coverage Status
Change from base Build 5941653747: 1.1%
Covered Lines: 26181
Relevant Lines: 30151

💛 - Coveralls

@olevski
Copy link
Member Author

olevski commented Aug 21, 2023

I tested by making a local renku project, running renku dataset import 10.5281/zenodo.7822477 and then running renku graph export.

The output is as follows (I removed all sections that are not related to dataset images):

...
    "http://schema.org/image": [
      {
        "@id": "https://localhost/datasets/e4d541b86d164541b57d885bdef19b7a/images/0"
      }
  },
  ...
  {
    "@id": "https://localhost/datasets/e4d541b86d164541b57d885bdef19b7a/images/0",
    "@type": [
      "http://schema.org/ImageObject"
    ],
    "http://schema.org/contentUrl": [
      {
        "@value": "https://zenodo.org/static/img/logos/zenodo-gradient-round.svg"
      }
    ],
    "http://schema.org/position": [
      {
        "@value": 1
      }
    ]
  },
  ]

@olevski olevski marked this pull request as ready for review August 21, 2023 20:29
@olevski olevski enabled auto-merge (squash) August 22, 2023 12:21
@olevski olevski deployed to renku-ci-rp-3596 August 22, 2023 12:21 — with GitHub Actions Active
@olevski olevski merged commit c6833be into develop Aug 22, 2023
24 of 27 checks passed
@olevski olevski deleted the fix-3582-renku-graph-export-with-zenodo-dataset branch August 22, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

renku graph export failed after importing DS from Zenodo
4 participants