Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): remove doctor check from cache.migrations_check #3597

Merged

Conversation

Panaetius
Copy link
Member

closes #3578

/deploy #persist

@Panaetius Panaetius requested a review from a team as a code owner August 22, 2023 15:47
@Panaetius Panaetius deployed to renku-ci-rp-3597 August 22, 2023 15:47 — with GitHub Actions Active
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-3597.dev.renku.ch

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5941092628

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 15 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.04%) to 85.668%

Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/ui/cli/init.py 1 96.9%
renku/ui/service/cache/models/file.py 1 93.15%
renku/command/rollback.py 2 78.7%
renku/ui/service/jobs/cleanup.py 2 80.65%
renku/ui/cli/service.py 3 66.67%
renku/command/checks/datasets.py 5 81.65%
Totals Coverage Status
Change from base Build 5931488864: -0.04%
Covered Lines: 25828
Relevant Lines: 30149

💛 - Coveralls

@Panaetius Panaetius mentioned this pull request Aug 22, 2023
@olevski olevski self-requested a review August 22, 2023 16:32
@Panaetius Panaetius merged commit ffd987e into develop Aug 22, 2023
28 of 30 checks passed
@Panaetius Panaetius deleted the fix/3578-remove-doctor-check-from-migrations-check branch August 22, 2023 16:41
@Panaetius Panaetius mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

move doctor check out of cache.migrations_check endpoint
4 participants