Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): ssh setup and key usage #3615

Merged
merged 6 commits into from Sep 26, 2023
Merged

fix(cli): ssh setup and key usage #3615

merged 6 commits into from Sep 26, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented Sep 12, 2023

closes #3585
closes #3584

I am not sure that getting into people's ssh configurations to such extent (as we currently do) is maintainable and feasible without a lot of edge cases or bugs. So I decided to simply give a warning when the renku session ssh-setup command is used. When I saw this command (including other users from discord) I expected that it would inject ssh keys into the current project. But it does not do this. It only generates/updates stuff in ~/.ssh/renku.

I think a more sustainable solution is to step back from doing all this ssh configuration manipulation for users. Because the biggest problem is that it is hard to make things work both with and without using the renku CLI. But we can discuss this further in a separate issue.

@coveralls
Copy link
Collaborator

coveralls commented Sep 12, 2023

Pull Request Test Coverage Report for Build 6310115018

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 54 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+1.0%) to 86.766%

Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/util/requests.py 1 94.69%
renku/core/util/tabulate.py 1 96.3%
renku/core/workflow/activity.py 1 93.93%
renku/ui/cli/init.py 1 96.9%
renku/ui/service/cache/models/file.py 1 93.15%
renku/command/rollback.py 2 78.7%
renku/core/util/os.py 2 88.38%
renku/ui/service/jobs/cleanup.py 2 80.65%
Totals Coverage Status
Change from base Build 6049920186: 1.0%
Covered Lines: 26167
Relevant Lines: 30158

💛 - Coveralls

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tasko! I've just added 2 comments regarding a message formatting/wording.

renku/core/session/session.py Outdated Show resolved Hide resolved
renku/core/session/session.py Outdated Show resolved Hide resolved
@olevski olevski enabled auto-merge (squash) September 26, 2023 08:37
@olevski olevski merged commit 3fa737a into develop Sep 26, 2023
26 of 28 checks passed
@olevski olevski deleted the 3584-fix-ssh-setup branch September 26, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
3 participants