Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): session pause and resume #3633

Merged
merged 5 commits into from Oct 10, 2023

Conversation

m-alisafaee
Copy link
Contributor

Description

Adds session pause and session resume commands.

Fixes #3621

@coveralls
Copy link
Collaborator

coveralls commented Oct 10, 2023

Pull Request Test Coverage Report for Build 6474615231

  • 47 of 164 (28.66%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 3621-session-hibernation-in-cli at 85.514%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/util/requests.py 1 2 50.0%
renku/domain_model/session.py 7 8 87.5%
renku/core/plugin/session.py 2 4 50.0%
renku/ui/cli/utils/plugins.py 1 3 33.33%
renku/command/session.py 5 8 62.5%
renku/ui/cli/utils/click.py 1 7 14.29%
renku/ui/cli/session.py 16 26 61.54%
renku/core/session/renkulab.py 6 39 15.38%
renku/core/session/session.py 8 67 11.94%
Totals Coverage Status
Change from base Build 6474604365: 85.5%
Covered Lines: 26275
Relevant Lines: 30726

💛 - Coveralls

@m-alisafaee m-alisafaee marked this pull request as ready for review October 10, 2023 07:27
@m-alisafaee m-alisafaee requested a review from a team as a code owner October 10, 2023 07:27
@m-alisafaee m-alisafaee force-pushed the 3621-session-hibernation-in-cli branch from 31f06e8 to 62200ee Compare October 10, 2023 11:25
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks all good!

@m-alisafaee m-alisafaee enabled auto-merge (squash) October 10, 2023 20:42
@m-alisafaee m-alisafaee merged commit f4b6480 into develop Oct 10, 2023
27 checks passed
@m-alisafaee m-alisafaee deleted the 3621-session-hibernation-in-cli branch October 10, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pause and resume sessions from CLI
4 participants