Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): output proper session link and only check registry if logged in #3660

Merged
merged 4 commits into from Jan 4, 2024

Conversation

Panaetius
Copy link
Member

closes #3659
closes #3658

@coveralls
Copy link
Collaborator

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7406917110

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 85.435%

Totals Coverage Status
Change from base Build 7401522025: -0.02%
Covered Lines: 26425
Relevant Lines: 30930

💛 - Coveralls

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Panaetius Panaetius enabled auto-merge (squash) December 20, 2023 08:05
@Panaetius Panaetius merged commit 12469f9 into develop Jan 4, 2024
27 checks passed
@Panaetius Panaetius deleted the fix/3659-fix-image-registry branch January 4, 2024 08:27
Panaetius pushed a commit that referenced this pull request Jan 15, 2024
* chore(service): return cli version in core svc (#3655)

* fix(cli): use lower case image names for sessions in upper-case projects (#3666)

* fix(service): add proper error if a dataset can't be found (#3661)

* fix: prevent distutils warning (#3663)

* fix(service): allow editing datasets without creator email (#3664)

* fix(cli): output proper session link and only check registry if logged in (#3660)

* fix(service): allow setting keywords on project creation (#3665)

* chore: combined dependency update (#3672)

bump dependencies, fix gitpython security advisory

* feat(service): date_published in datasets.list response (#3648)

* fix(service): fix clone depth not being respected (#3678)

* chore: release v2.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

CLI uses the wrong gitlab registry Open the right link for Jupyterlab when running in docker
3 participants