Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): add proper error if a dataset can't be found #3661

Merged
merged 3 commits into from Dec 21, 2023

Conversation

Panaetius
Copy link
Member

closes #3593

@coveralls
Copy link
Collaborator

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7286153252

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 6 of 9 (66.67%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.006%) to 85.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/views/error_handlers.py 1 2 50.0%
renku/ui/service/errors.py 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 78.31%
renku/ui/service/cache/models/file.py 1 93.15%
renku/ui/service/jobs/cleanup.py 2 80.65%
Totals Coverage Status
Change from base Build 7278525380: 0.006%
Covered Lines: 26413
Relevant Lines: 30901

💛 - Coveralls

@Panaetius Panaetius force-pushed the fix/3593-svc-dataset404-error branch from 13cd9b5 to ef0d851 Compare December 1, 2023 11:01
@Panaetius Panaetius enabled auto-merge (squash) December 21, 2023 09:11
@Panaetius Panaetius merged commit 8afaedd into develop Dec 21, 2023
27 checks passed
@Panaetius Panaetius deleted the fix/3593-svc-dataset404-error branch December 21, 2023 09:38
Panaetius pushed a commit that referenced this pull request Jan 15, 2024
* chore(service): return cli version in core svc (#3655)

* fix(cli): use lower case image names for sessions in upper-case projects (#3666)

* fix(service): add proper error if a dataset can't be found (#3661)

* fix: prevent distutils warning (#3663)

* fix(service): allow editing datasets without creator email (#3664)

* fix(cli): output proper session link and only check registry if logged in (#3660)

* fix(service): allow setting keywords on project creation (#3665)

* chore: combined dependency update (#3672)

bump dependencies, fix gitpython security advisory

* feat(service): date_published in datasets.list response (#3648)

* fix(service): fix clone depth not being respected (#3678)

* chore: release v2.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Dataset error from API for DatasetNotFound
3 participants