Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): use lower case image names for sessions in upper-case projects #3666

Merged
merged 2 commits into from Dec 20, 2023
Merged

fix(cli): use lower case image names for sessions in upper-case projects #3666

merged 2 commits into from Dec 20, 2023

Conversation

Panaetius
Copy link
Member

closes #3607

@Panaetius Panaetius requested a review from a team as a code owner December 8, 2023 13:54
@coveralls
Copy link
Collaborator

coveralls commented Dec 8, 2023 •
edited

Pull Request Test Coverage Report for Build 7278198445

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.06%) to 85.437%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/session/session.py 2 3 66.67%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 72.49%
Totals Coverage Status
Change from base Build 7272884200: 0.06%
Covered Lines: 26394
Relevant Lines: 30893
💛 - Coveralls

@Panaetius Panaetius enabled auto-merge (squash) December 20, 2023 16:33
@Panaetius Panaetius merged commit ec1e282 into develop Dec 20, 2023
26 of 27 checks passed
@Panaetius Panaetius deleted the fix/3607-session-capital-letters branch December 20, 2023 17:03
Panaetius pushed a commit that referenced this pull request Jan 15, 2024
@github-actions
chore: release v2.8.2 (#3684)
50d1a5f 
* chore(service): return cli version in core svc (#3655)

* fix(cli): use lower case image names for sessions in upper-case projects (#3666)

* fix(service): add proper error if a dataset can't be found (#3661)

* fix: prevent distutils warning (#3663)

* fix(service): allow editing datasets without creator email (#3664)

* fix(cli): output proper session link and only check registry if logged in (#3660)

* fix(service): allow setting keywords on project creation (#3665)

* chore: combined dependency update (#3672)

bump dependencies, fix gitpython security advisory

* feat(service): date_published in datasets.list response (#3648)

* fix(service): fix clone depth not being respected (#3678)

* chore: release v2.8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-alisafaee m-alisafaee m-alisafaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
renku-python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle capitalization for session providers in the CLI
3 participants
@Panaetius @coveralls @m-alisafaee