Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): dataset import error #3670

Merged
merged 1 commit into from Dec 15, 2023
Merged

Conversation

m-alisafaee
Copy link
Contributor

Description

Renaming name to slug was not done for a service function which caused an exception when importing datasets from UI.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7198328761

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 85.484%

Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 78.31%
Totals Coverage Status
Change from base Build 7156809693: -0.01%
Covered Lines: 26406
Relevant Lines: 30890

💛 - Coveralls

Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this

@m-alisafaee m-alisafaee merged commit 1795cde into develop Dec 15, 2023
32 checks passed
@m-alisafaee m-alisafaee deleted the bugfix/service-import-error branch December 15, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants