fix(service): fix clone depth not being respected #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panaetius
had a problem deploying
to
renku-ci-rp-3678
GitHub Actions
Error
Panaetius
temporarily deployed
to
renku-ci-rp-3678
GitHub Actions
Inactive
|
You can access the deployment of this PR at https://renku-ci-rp-3678.dev.renku.ch |
Pull Request Test Coverage Report for Build 7529633125
💛 - Coveralls |
Panaetius
force-pushed
the
fix-svc-clone-depth
branch
from
ac91912
to
2e17a83
Compare
Panaetius
temporarily deployed
to
renku-ci-rp-3678
GitHub Actions
Inactive
Panaetius
force-pushed
the
fix-svc-clone-depth
branch
from
2e17a83
to
0573cd1
Compare
Panaetius
had a problem deploying
to
renku-ci-rp-3678
GitHub Actions
Error
Panaetius
force-pushed
the
fix-svc-clone-depth
branch
from
0573cd1
to
53a5cdd
Compare
Panaetius
temporarily deployed
to
renku-ci-rp-3678
GitHub Actions
Inactive
Panaetius
force-pushed
the
fix-svc-clone-depth
branch
from
53a5cdd
to
73803c1
Compare
Panaetius
temporarily deployed
to
renku-ci-rp-3678
GitHub Actions
Inactive
Panaetius
force-pushed
the
fix-svc-clone-depth
branch
from
73803c1
to
90a3db4
Compare
Panaetius
temporarily deployed
to
renku-ci-rp-3678
GitHub Actions
Inactive
|
Wow so this is because the parameters to the git python function we call changed? Like from |
olevski
approved these changes
Jan 15, 2024
yes, and because we had the unknown=ignore part, we just never noticed... |
Panaetius
pushed a commit
that referenced
this pull request
Jan 15, 2024
* chore(service): return cli version in core svc (#3655) * fix(cli): use lower case image names for sessions in upper-case projects (#3666) * fix(service): add proper error if a dataset can't be found (#3661) * fix: prevent distutils warning (#3663) * fix(service): allow editing datasets without creator email (#3664) * fix(cli): output proper session link and only check registry if logged in (#3660) * fix(service): allow setting keywords on project creation (#3665) * chore: combined dependency update (#3672) bump dependencies, fix gitpython security advisory * feat(service): date_published in datasets.list response (#3648) * fix(service): fix clone depth not being respected (#3678) * chore: release v2.8.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we always did a full clone instead of shallow when a user is logged in.
/deploy extra-values=global.renku.cli_version=2.8.0