Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): migrate Dockerfile after metadata #3690

Merged
merged 4 commits into from Feb 5, 2024
Merged

Conversation

Panaetius
Copy link
Member

properly fixes migration issues.
Docker/Template migration is now done after metadata migration and double checks if the Dockerfile can be migrated.

@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2024

Pull Request Test Coverage Report for Build 7790158199

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • -2 of 29 (93.1%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 85.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/migration/migrate.py 22 24 91.67%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 64.76%
renku/ui/cli/init.py 1 96.95%
renku/ui/cli/service.py 1 78.31%
renku/command/rollback.py 2 78.7%
Totals Coverage Status
Change from base Build 7787455799: 0.01%
Covered Lines: 26659
Relevant Lines: 31304

💛 - Coveralls

Copy link
Contributor

@m-alisafaee m-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Panaetius Panaetius enabled auto-merge (squash) February 5, 2024 20:01
@Panaetius Panaetius merged commit e98f112 into develop Feb 5, 2024
27 checks passed
@Panaetius Panaetius deleted the fix-migration-order branch February 5, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants