Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotfix migration timezones #683

Merged
merged 5 commits into from Sep 18, 2019
Merged

fix: hotfix migration timezones #683

merged 5 commits into from Sep 18, 2019

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Sep 18, 2019

Closes #678

Removes need for pytz from dataset migration relevant code.

Updates run-tests.sh to test docs and unit-tests separately, reducing the potential for dependency leakage into unit tests

Updates travis-ci and github actions for the updated run-tests.sh script

@Panaetius Panaetius requested a review from a team as a code owner September 18, 2019 12:23
Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

@jsam jsam changed the title Hotfix migration timezones fix: hotfix migration timezones Sep 18, 2019
@jsam jsam merged commit 58c2de4 into master Sep 18, 2019
@jsam jsam deleted the hotfix-migration-timezones branch September 18, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pytz dependency and wrong unit-test dependencies
2 participants