Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dataset import causes renku exception due to duplicate LocalClient #724

Merged
merged 4 commits into from Oct 2, 2019

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Oct 1, 2019

Closes #718

Replaced code with a decorated wrapper function and the actual functionality so a client can be manually passed to the function if necessary.

@Panaetius Panaetius requested a review from a team as a code owner October 1, 2019 11:21
@Panaetius Panaetius changed the title [WIP]fix: doesn't create new client if client is already passed fix: doesn't create new client if client is already passed Oct 1, 2019
renku/cli/dataset.py Show resolved Hide resolved
renku/cli/_client.py Outdated Show resolved Hide resolved
@Panaetius Panaetius changed the title fix: doesn't create new client if client is already passed fix: dataset import causes renku exception due to duplicate LocalClient Oct 1, 2019
@jsam jsam merged commit 89411b0 into master Oct 2, 2019
@jsam jsam deleted the 718-fix-import branch October 2, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dataset import fails with lock error
2 participants