Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes bug with deleted files not getting committed #741

Merged
merged 4 commits into from Oct 8, 2019

Conversation

Panaetius
Copy link
Member

@Panaetius Panaetius commented Oct 4, 2019

There was a check to make sure only files that exist get added to ggit, which is not the case for files that were deleted. Now deleted files get added despite this check, though the check remains in place for all other changes.

Fixes #708

@Panaetius Panaetius requested a review from a team as a code owner October 4, 2019 15:07
@jsam jsam changed the title Fixes bug with deleted files not getting commited fix: fixes bug with deleted files not getting committed Oct 7, 2019
Copy link
Contributor

@jsam jsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good. Thank you.

@Panaetius Panaetius merged commit 5de4b6f into master Oct 8, 2019
@Panaetius Panaetius deleted the 708-fix-dataset-rm branch October 8, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

renku dataset rm <dataset> does not commit the deletions
2 participants