Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add styles for project and dataset cards (#1964) #1978

Merged
merged 5 commits into from Aug 10, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Jul 29, 2022

This PR add the styles for project and dataset cards and the button to start a session from the project card.

card-styles

Ref #1964

Pending

  • Fix acceptance tests

/deploy renku=1978-styles-cards-projects-and-datasets #persist

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1978.dev.renku.ch

@andre-code
Copy link
Contributor Author

Note: we agreed with Ordes not to merge it into master but into a feature branch while making the internal card for projects and datasets.

@andre-code andre-code force-pushed the 1964-project-dataset-card-styles branch from ac11853 to 26470ff Compare July 29, 2022 07:23
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 July 29, 2022 07:23 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 July 29, 2022 09:03 Inactive
@andre-code andre-code force-pushed the 1964-project-dataset-card-styles branch from 26470ff to c81077c Compare July 29, 2022 16:08
@andre-code andre-code marked this pull request as ready for review July 29, 2022 16:08
@andre-code andre-code requested a review from a team as a code owner July 29, 2022 16:08
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 July 29, 2022 16:42 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1978 August 2, 2022 11:51 Inactive
@ciyer ciyer changed the base branch from master to ux-cards August 3, 2022 09:59
@ciyer ciyer force-pushed the 1964-project-dataset-card-styles branch from 3d14815 to 2cd326a Compare August 3, 2022 11:30
@ciyer ciyer force-pushed the 1964-project-dataset-card-styles branch from 2cd326a to 05393e7 Compare August 5, 2022 12:04
@ciyer ciyer temporarily deployed to renku-ci-ui-1978 August 5, 2022 12:30 Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-1978 August 5, 2022 13:25 Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

For the most part, I think the code is good, I think it could benefit from introducing a few more components in client/src/utils/components/List.js. I made a commit that starts this, but I think it could go a bit further.

The other thing that would be nice is to use SVG for the background images. I think the PNG files look grainy.

@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 8, 2022 09:19 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 8, 2022 09:40 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 8, 2022 11:20 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 8, 2022 12:48 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 8, 2022 13:21 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 9, 2022 09:14 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 9, 2022 11:28 Inactive
@andre-code
Copy link
Contributor Author

This looks good!

For the most part, I think the code is good, I think it could benefit from introducing a few more components in client/src/utils/components/List.js. I made a commit that starts this, but I think it could go a bit further.

Thanks for the feedback, I have also added new components in the List.js. Note that in kg-search that component is refactored, so in this PR I only focus on the styles and don't make this PR so extensive.

The other thing that would be nice is to use SVG for the background images. I think the PNG files look grainy.

That grainy effect is intentional in the design, those resources in Figma and zeroheight are only available in png, and I think it makes sense because they are 2 images combined.

@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 9, 2022 12:51 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 9, 2022 13:06 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 9, 2022 14:27 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-1978 August 9, 2022 14:53 Inactive
@andre-code andre-code deployed to renku-ci-ui-1978 August 10, 2022 05:59 Active
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andre-code andre-code merged commit 4cc2686 into ux-cards Aug 10, 2022
@andre-code andre-code deleted the 1964-project-dataset-card-styles branch August 10, 2022 11:33
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@ciyer ciyer added this to the 2.7.0 milestone Aug 11, 2022
andre-code added a commit that referenced this pull request Aug 16, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
andre-code added a commit that referenced this pull request Aug 16, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
andre-code added a commit that referenced this pull request Aug 19, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
andre-code added a commit that referenced this pull request Aug 29, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
ciyer pushed a commit that referenced this pull request Sep 2, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
ciyer pushed a commit that referenced this pull request Sep 2, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
andre-code added a commit that referenced this pull request Sep 6, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
andre-code added a commit that referenced this pull request Sep 9, 2022
 Add styles for project and dataset cards, add start a session from project card

Co-authored-by: Chandrasekhar Ramakrishnan <cramakri@ethz.ch>

Fix #1964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants