New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add styles for project and dataset cards (#1964) #1978
Conversation
You can access the deployment of this PR at https://renku-ci-ui-1978.dev.renku.ch |
Note: we agreed with Ordes not to merge it into master but into a feature branch while making the internal card for projects and datasets. |
ac11853
to
26470ff
Compare
26470ff
to
c81077c
Compare
3d14815
to
2cd326a
Compare
2cd326a
to
05393e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
For the most part, I think the code is good, I think it could benefit from introducing a few more components in client/src/utils/components/List.js
. I made a commit that starts this, but I think it could go a bit further.
The other thing that would be nice is to use SVG for the background images. I think the PNG files look grainy.
Thanks for the feedback, I have also added new components in the List.js. Note that in kg-search that component is refactored, so in this PR I only focus on the styles and don't make this PR so extensive.
That grainy effect is intentional in the design, those resources in Figma and zeroheight are only available in png, and I think it makes sense because they are 2 images combined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Tearing down the temporary RenkuLab deplyoment for this PR. |
This PR add the styles for project and dataset cards and the button to start a session from the project card.
Ref #1964
Pending
/deploy renku=1978-styles-cards-projects-and-datasets #persist