New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow up to 100 namespaces and sort them #2606
Conversation
You can access the deployment of this PR at https://renku-ci-ui-2606.dev.renku.ch |
e9d68fb
to
a907e1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as advertised. Since it's intended as a quick fix, we can merge it as is.
Ideally, it would be nice to move the Namespace
type to a definition file and parametrize both per_page
and owned_only
since we are touching that code already.
why not use pagination properly? This is just going to break for someone else later. |
I suggest merging this as is since it's just a quick fix and users have asked for it. We can definitely improve the logic but I would like to explore a more comprehensive solution for pagination that we can reuse for similar cases. The React Toolkit library we are using doesn't provide an out-of-the-box solution but suggests a way (REF). In general, the solution should make it easy to assess at any point whether some items have already been fetched and whether more are loading. In this case, after fetching the first page, we can let the user pick a namespace already and show a loading wheel to let the user know we are still loading more items. |
Tearing down the temporary RenkuLab deplyoment for this PR. |
Follow-up issue: #2618 |
Some users have more than 20 namespaces. Increase the limit used when showing the namespace list in the project creation dropdown.
/deploy #persist #cypress