Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dataset delete is possible again #2607

Merged
merged 4 commits into from Jun 21, 2023
Merged

fix: dataset delete is possible again #2607

merged 4 commits into from Jun 21, 2023

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jun 19, 2023

Deleting a dataset was broken. This should fix that feature again.

/deploy #persist #cypress

@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 19, 2023 11:03 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2607.dev.renku.ch

ciyer pushed a commit that referenced this pull request Jun 19, 2023
@cramakri
fix: dataset delete is possible again (#2607)
03d9a1e
@ciyer ciyer force-pushed the ciyer/000-delete-dataset-fix branch from 61f5d04 to 03d9a1e Compare June 19, 2023 11:43
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 19, 2023 11:43 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 19, 2023 14:48 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 20, 2023 06:36 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 20, 2023 07:54 — with GitHub Actions Inactive
ciyer pushed a commit that referenced this pull request Jun 20, 2023
@cramakri
fix: dataset delete is possible again (#2607)
8b456fa
@ciyer ciyer force-pushed the ciyer/000-delete-dataset-fix branch from f3a10ef to 8b456fa Compare June 20, 2023 08:39
ciyer pushed a commit that referenced this pull request Jun 20, 2023
@cramakri
fix: dataset delete is possible again (#2607)
6305462
@ciyer ciyer force-pushed the ciyer/000-delete-dataset-fix branch from 8b456fa to 6305462 Compare June 20, 2023 08:39
@ciyer ciyer marked this pull request as ready for review June 20, 2023 08:39
@ciyer ciyer requested a review from a team as a code owner June 20, 2023 08:39
@ciyer ciyer force-pushed the ciyer/000-delete-dataset-fix branch from 6305462 to 11579ed Compare June 20, 2023 08:51
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 20, 2023 08:51 — with GitHub Actions Inactive
leafty
leafty previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Code looks good! A few non-blocking code suggestions below.

client/src/project/datasets/delete/DeleteDataset.present.js Outdated Show resolved Hide resolved
client/src/project/datasets/delete/DeleteDataset.present.js Outdated Show resolved Hide resolved
tests/cypress/e2e/projectDatasets.spec.ts Outdated Show resolved Hide resolved
tests/cypress/e2e/projectDatasets.spec.ts Show resolved Hide resolved
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 21, 2023 06:53 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 21, 2023 08:25 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2607 June 21, 2023 10:26 — with GitHub Actions Inactive
@ciyer ciyer deployed to renku-ci-ui-2607 June 21, 2023 12:05 — with GitHub Actions Active
@ciyer ciyer merged commit 6efb46d into master Jun 21, 2023
12 of 14 checks passed
@ciyer ciyer deleted the ciyer/000-delete-dataset-fix branch June 21, 2023 14:29
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ciyer @RenkuBot @leafty @cramakri