Remove form generator completely

[ciyer]

• Remove form generator from dataset edit path
• Remove form generator code

Fix #2622
Fix #2356
Fix #1930

/deploy #persist #cypress renku=renku-ui-3.10-tests extra-values=core.horizontalPodAutoscaling.minReplicas=1,core.replicaCount=1

[RenkuBot]

You can access the deployment of this PR at https://renku-ci-ui-2628.dev.renku.ch

[lorenzo-cavazzi]

Wow, quite some changes in this PR 🚀

The code looks great already! I found a few little issues -- some not necessarily related to changes you introduced but just in the code you moved around or touched:

• The cards in the datasets project tab look a bit broken
  

• The same goes for some of the Cards inside the dataset details page
  

• (Not new to this PR, but worth fixing) the "Deleting datasets" message we show in the "Delete Dataset" modal floats to the right
  

• This is not UI related, but I couldn't fully test a few operations due to the renku-core problems. E.G. importing a dataset into a project never ended even though it was imported.
  Do you mind adding these extra values to the deploy string? It should also help with the tests extra-values=core.horizontalPodAutoscaling.minReplicas=1,core.replicaCount=1
  

[lorenzo-cavazzi]

This looks ready!

One detail: does it actually fix #1930 ? I still see the folders expanded on dataset view and edit pages

[ciyer]

Thanks for the review. All good points! I have addressed all your requests, I think. The dataset delete now looks like this:

[ciyer]

One detail: does it actually fix #1930 ? I still see the folders expanded on dataset view and edit pages

Yes, there is now a more intelligent logic to determine if the folder should be displayed open or closed. The top level is shown opened if there are less than 5 elements there. See https://renku-ci-ui-2628.dev.renku.ch/projects/sean/another-playground-project/datasets/using_open_citation_data/

[lorenzo-cavazzi]

Yes, there is now a more intelligent logic to determine if the folder should be displayed open or closed. The top level is shown opened if there are less than 5 elements there.

I see. It's a bit different than what the original issue suggested and I fear it might not work well in some scenarios (e.g. more deeply nested folder structures with fewer elements per folder) but let's give this a go

[lorenzo-cavazzi]

🚀

[RenkuBot]

Tearing down the temporary RenkuLab deplyoment for this PR.