Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project does not show up in dashboard when the user has been granted access to it #2657

Closed
olevski opened this issue Jul 13, 2023 · 4 comments
Labels
status/wontfix Will not be implemented

Comments

@olevski
Copy link
Member

olevski commented Jul 13, 2023

I am not sure this is a bug or not. But when we relied on gitlab if someone gave you access to a project (that you previously had no access to) then that project would bubble up to the top of the list in the home page / dashboard.

But now with the switch to the KG we do not capture this scenario. So if someone has been granted access to a project and they go to renku then they have to manually search for this project.

A user posted about this on discourse. See here: https://renku.discourse.group/t/linking-back-from-gitlab-to-renkulab-project/846

@olevski olevski added the status/triage Issue needs to be triaged label Jul 13, 2023
@lorenzo-cavazzi
Copy link
Member

But now with the switch to the KG we do not capture this scenario.

This seems unrelated to using KG. Regardless of the access level or ownership, we show the recently accessed project in the dashboard. Users need to visit the project once to have it on their dashboard

@olevski
Copy link
Member Author

olevski commented Jul 14, 2023

But now with the switch to the KG we do not capture this scenario.

This seems unrelated to using KG. Regardless of the access level or ownership, we show the recently accessed project in the dashboard. Users need to visit the project once to have it on their dashboard

@lorenzo-cavazzi yes but when we depended on gitlab to list the projects, then when you were added to a project that project showed up in your dashboard/list. Now that behaviour is gone.

I think it is very unintuitive (just as the user explains in the discourse post) that when you get added to a project you then have to go digging for it in the renku search. And the renku search is not very good so you usually get a lot of hits and you have to sift through them to find the actual project you were added to.

I know this may not be easy to fix. But we should try to do something about it. And changes may need to be done perhaps on both the UI and KG side.

@lorenzo-cavazzi
Copy link
Member

Sorry this is getting a bit confusing. Let me quickly recap.

  • Before introducing the new dashboard, we showed the last 4 projects the user had access to. If someone else added you to a project, you might have seen it if there were recent changes compared to your other projects. If not, you had to search for it on the projects page.
  • Since the dashboard was introduced, we started using the UI server to cache the last visited projects and show those. This hasn't changed yet and KG is not involved in this process. If you have yet to visit the project you have been added to, you need to use the search page to find it.
  • We plan to phase out the UI server API and switch to KG (refactor(client): use the recently-viewed API from KG #2599); the behavior will be similar, and we will also allow users to filter for their projects (Show only own and forked projects in dashboard #2522). This will probably happen within the next sprint.

Pushing projects you gained access to to the top was never considered in these scenarios. We just switched the logic from "last modified project" to "last visited project".
If your request is to show some sort of notification when users gain access to a new project, it sounds reasonable but I don't think it has to do with the dashboard.
If you believe the dashboard should behave differently, I'm happy to discuss this (perhaps the Product team is a better start), but I'm not sure there is any easy way to address the original problem through the dashboard.

@lorenzo-cavazzi lorenzo-cavazzi added status/wontfix Will not be implemented and removed status/triage Issue needs to be triaged labels Nov 3, 2023
@lorenzo-cavazzi
Copy link
Member

I'm closing this since the current behavior is "by design" and changing it requires planning through a pitch.
Still, I agree users should have quicker access to newly created projects. It will be easier once Renku native projects are rolled out.

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/wontfix Will not be implemented
Projects
None yet
Development

No branches or pull requests

2 participants