Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate notebooks admin page into UI #351

Closed
3 tasks done
rokroskar opened this issue Nov 22, 2018 · 2 comments
Closed
3 tasks done

Integrate notebooks admin page into UI #351

rokroskar opened this issue Nov 22, 2018 · 2 comments

Comments

@rokroskar
Copy link
Member

rokroskar commented Nov 22, 2018

With #331 merged we can make requests to the notebook service directly from the UI. We should now be able to greatly simplify the notebook server interactions.

First steps:

  • Create a new "Notebook Servers" tab in the project view
  • Display the information currently presented in a separate browser tab served from https://<renku-domain>/jupyterhub/services/notebooks/ui/ in the above tab
  • Add the "connect" and "stop" options per notebook server

Some ideas for further improvements:

  • the notebook server button itself could reflect the status of the running server for the selected project
  • the project view page could include an icon to connect to a running server
  • there could be a global page per user on the platform level to display running servers
  • the notebook servers tab could display further relevant information like e.g. running commit, branch, time inactive etc.
@lorenzo-cavazzi lorenzo-cavazzi moved this from To Do to In Progress in Feb 2019: Onboard New UI Devs Feb 11, 2019
@ableuler ableuler changed the title rework notebook launch and status Integrate notebooks admin page into UI Feb 11, 2019
@lorenzo-cavazzi
Copy link
Member

Would embedding the https://<renku-domain>/jupyterhub/services/notebooks/ui/ page in the tab through an <iframe> be an acceptable solution? I believe this would easily satisfy the requirements in the first steps, but then we won't be able to customize the page further.

Anyway this would be the result

image

@ciyer
Copy link
Contributor

ciyer commented Feb 13, 2019

Cute idea, but this is not the solution I had in mind. :)

You should use the code here https://github.com/SwissDataScienceCenter/renku-notebooks/tree/master/src/ui as the starting point. Try to move that code into the renku-ui. You may encounter authentication or same-origin policy problems, so be on the lookout for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

3 participants