-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix running in docker #51
Conversation
Hi ruudvd, thanks for trying out our project and for the feedback. Sorry about the error with aiofile package. It happens that this package was added to the pyproject.toml as a dev dependency and in fact is in the right place as aiofile is used in the simulator.py, which is just an example and must not be treated as part of the package. I opened a PR where I install the aiofile on running time, avoiding adding the package as a prod dependency. Regarding the Docker error, I must say I also experienced the same Error in MacOS, something I didnt experience before. As a workaround what I do is after stopping the container, to rm the stopped containers with |
1 similar comment
Hi ruudvd, thanks for trying out our project and for the feedback. Sorry about the error with aiofile package. It happens that this package was added to the pyproject.toml as a dev dependency and in fact is in the right place as aiofile is used in the simulator.py, which is just an example and must not be treated as part of the package. I opened a PR where I install the aiofile on running time, avoiding adding the package as a prod dependency. Regarding the Docker error, I must say I also experienced the same Error in MacOS, something I didnt experience before. As a workaround what I do is after stopping the container, to rm the stopped containers with |
I tested the PR with the changed aiofile and the docker workaround, it worked. |
yup, there are few number of times that we can send an SDP request until the system actually crashes, so what you see is the EVCC starting first and has to wait for the SECC to be receptive to process the SDP request. We have set in docker compose a requirement for the EVCC to start after the SECC does, but that is just related to the container startup, not to the application startup. |
I tested the ISO15118 docker-compose file and ran into a few issues:
I fixed this by moving
aiofile
dependencyAfter i added a sleep of 1 sec before running the executable i got this:
the
TLS server started at ..
andTCP server started at ..
is the docker container network not yet started when the execuable is ran?used setup
Pop!_OS 21.10
Docker version 20.10.12, build e91ed57
docker-compose version 1.29.2, build 5becea4c