Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to create symfony recipe for a plugin created with this skeleton due to payum #183

Open
jacquesbh opened this issue Feb 25, 2020 · 2 comments
Labels

Comments

@jacquesbh
Copy link
Member

Hi!

Let's keep it simple: https://travis-ci.org/symfony/recipes-contrib/jobs/654942372
This link is the CI testing the recipe for a plugin.
The plugin is really simple and requires sylius/sylius=~1.3.

The plugin works well.

But when we want to create a recipe it gives an issue about payum. It should not.

I'm trying to change the way I require sylius in the plugin but I think we may have an issue here.

Is there any chance a core team developer could take a look at it?

Thank you!

@jacquesbh jacquesbh changed the title Impossible to create symfony recipe for a plugin created with this skeleton Impossible to create symfony recipe for a plugin created with this skeleton due to payum Feb 25, 2020
@Zales0123
Copy link
Member

Hello Jacques!

The problem with flex recipes for plugins is deeper 🕳 There are no recipes for Sylius extracted bundled (like SyliusResourceBundle) and therefore for Sylius itself as well. As you can see, on the Travis, the test consists of installing a bundle (a Sylius plugin, in this case), on symfony/skeleton application. I don't know if it's related to this, but even if not, there would be some more problems after solving it. Plugins required sylius properly configured, which cannot be done automatically without a recipe for sylius/sylius 😢

We were lucky with our plugins 😄 as recipes for them were created where there was no such a check yet (only symfony flex bot, see this PR). But when we wanted to improve something, a similar thing happened.

For sure we would like to provide some recipes for all our bundles and Sylius itself 🖖 I'll let you know when it's done :)

@jacquesbh
Copy link
Member Author

jacquesbh commented Mar 2, 2020

Let's see how it goes: Payum/PayumBundle#511
Because for now my issue is Payum.

Maybe when Payum is resolved I'll have more problems :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants