Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test app API #321

Merged
merged 4 commits into from
Mar 9, 2022
Merged

Fix test app API #321

merged 4 commits into from
Mar 9, 2022

Conversation

vvasiloi
Copy link
Contributor

@vvasiloi vvasiloi commented Mar 2, 2022

Fix and enable the API in test app.

@vvasiloi vvasiloi requested a review from a team as a code owner March 2, 2022 22:27
.github/workflows/build.yml Outdated Show resolved Hide resolved
Comment on lines 3 to 11
sylius.security.api_regex: "^/api"
sylius.security.shop_regex: "^/(?!%sylius_admin.path_name%|new-api|api/.*|api$|media/.*)[^/]++"
sylius.security.new_api_route: "/new-api"
sylius.security.shop_regex: "^/(?!%sylius_admin.path_name%|api/.*|api$|media/.*)[^/]++"
sylius.security.new_api_route: "/api/v2"
sylius.security.new_api_regex: "^%sylius.security.new_api_route%"
sylius.security.new_api_admin_route: "%sylius.security.new_api_route%/admin"
sylius.security.new_api_admin_regex: "^%sylius.security.new_api_admin_route%"
sylius.security.new_api_shop_route: "%sylius.security.new_api_route%/shop"
sylius.security.new_api_shop_regex: "^%sylius.security.new_api_shop_route%"
sylius.security.new_api_user_account_route: "%sylius.security.new_api_shop_route%/account"
sylius.security.new_api_user_account_regex: "^%sylius.security.new_api_user_account_route%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no further need to define these parameters as there was extracted to bundles in Sylius in 1.9 version I guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simply copied it from Sylius-Standard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check if they're necessary and remove if not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right @GSadee, all those parameters are already defined in bundles, so I removed them from the test app.

@GSadee GSadee changed the base branch from master to 1.11 March 9, 2022 07:54
@GSadee
Copy link
Member

GSadee commented Mar 9, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "fix-api" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee merged commit 542ac1b into Sylius:1.11 Mar 9, 2022
@GSadee
Copy link
Member

GSadee commented Mar 9, 2022

Thanks, Victor! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants