[Maintenance] Annotation changed to PHP Attributes in the Entity classes #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of annotations
loic425
approved these changes
Nov 3, 2022
jakubtobiasz
approved these changes
Nov 3, 2022
NoResponseMate
approved these changes
Nov 3, 2022
coldic3
approved these changes
Nov 3, 2022
|
Thank you, Rafał! 🎉 |
Zales0123
added a commit
that referenced
this pull request
Nov 29, 2022
…n the Entity classes" (Zales0123) This PR was merged into the 1.12 branch. Discussion ---------- Reverts #865 It was probably merged too fast, we should make a smoother transition path with the usage of both attributes and annotations at the beginning 🖖 Reverting it to release 1.12.2 and introducing attributes usage properly in the nearest future. Discussion on Sylius Devs Slack that lead to this revert: https://sylius-devs.slack.com/archives/C9GQMG316/p1669720969325669 Commits ------- 1bdd549 Revert "[Maintenance] Annotation changed to PHP Attributes in the Entity classes"
jakubtobiasz
added a commit
that referenced
this pull request
Dec 22, 2022
This PR was merged into the 1.12 branch. Discussion ---------- The follow-up to: #865 & #881 Since we do not use PHP 7.4 anymore, it's preferable <s>to move into PHP Attributes</s> to support both annotations and attributes with default annotations setting 🎉 Commits ------- 05892c9 [Maintenance] PHP Attributes in the Entity classes
windragon0910
added a commit
to windragon0910/symfony_ecom_framework
that referenced
this pull request
Oct 25, 2023
…n the Entity classes" (Zales0123) This PR was merged into the 1.12 branch. Discussion ---------- Reverts Sylius/Sylius-Standard#865 It was probably merged too fast, we should make a smoother transition path with the usage of both attributes and annotations at the beginning 🖖 Reverting it to release 1.12.2 and introducing attributes usage properly in the nearest future. Discussion on Sylius Devs Slack that lead to this revert: https://sylius-devs.slack.com/archives/C9GQMG316/p1669720969325669 Commits ------- 1bdd5496a3baaae02dc58c5422af78dafe9b8593 Revert "[Maintenance] Annotation changed to PHP Attributes in the Entity classes"
windragon0910
added a commit
to windragon0910/symfony_ecom_framework
that referenced
this pull request
Oct 25, 2023
This PR was merged into the 1.12 branch. Discussion ---------- The follow-up to: Sylius/Sylius-Standard#865 & Sylius/Sylius-Standard#881 Since we do not use PHP 7.4 anymore, it's preferable <s>to move into PHP Attributes</s> to support both annotations and attributes with default annotations setting 🎉 Commits ------- 05892c9b5c34bf6b38f9b8dc21604c3606aadf43 [Maintenance] PHP Attributes in the Entity classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we do not use PHP 7.4 anymore, it's preferable to move into PHP Attributes