PHP Attributes support in controllers #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafikooo
force-pushed
the
support-attributes
branch
from
2b00c1e
to
b4310f9
Compare
diimpp
approved these changes
Oct 20, 2023
Wojdylak
approved these changes
Oct 24, 2023
oallain
approved these changes
Nov 11, 2023
Rafikooo
force-pushed
the
support-attributes
branch
from
b4310f9
to
17ae9b1
Compare
|
Thank you, @Rafikooo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces PHP attribute handling in controllers
Reference: https://symfony.com/doc/current/routing.html#creating-routes-as-attributes
Since this branch supports
Sylius 1.12andSymfony 5.4.*, the configuration had to be adjusted according to these docs:https://symfony.com/doc/5.4/routing.html#creating-routes-as-attributes-or-annotations