Add scalar types in Behat/Page/Admin directory #10045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Million years ago, we introduced scalar types to Sylius code (#8425) and it is a blessing :) However, our (big and strong) Behat-related code is still missing them. I know, they're not so valuable for the test code, but still allows us to reduce amount of unnecessary inaccuracies (and code lines :)). We should do something about it, or we will stay without these PHP7 features until PHP8 馃槃
This PR aims to add scalar types only in admin pages, which means
src/Sylius/Behat/Page/Admin
directory. Rest of the changes are just required to avoid failing tests. I believe it's doable to introduce scalar types in a reasonable amount of time and energy for the whole Behat suite, but it should be done in separated PR's per section.To be honest, it was not so bad as I've expected 馃悆