-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product attribute fixtures improvements #10165
Product attribute fixtures improvements #10165
Conversation
src/Sylius/Bundle/CoreBundle/Fixture/Factory/ProductExampleFactory.php
Outdated
Show resolved
Hide resolved
But huge 👏 for resolving bug itself ;) |
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
75f035c
to
14c2b05
Compare
485d2ea
to
40a8c5d
Compare
28c62c3
to
c4f0fc7
Compare
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
Thank you, Mateusz! 🎉 |
There was an issue with product attribute fixtures, that there was no possibility to use more sophisticated attributes in product fixtures (like
select
ordatetime
). I decided to create a functional PHPUnit test for this bugfix, as Behat scenario would be a little bit strange and too technical, in my opinion.