Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product attribute fixtures improvements #10165

Merged
merged 10 commits into from
Jun 24, 2019

Conversation

Zales0123
Copy link
Member

@Zales0123 Zales0123 commented Feb 11, 2019

Q A
Branch? 1.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #9252
License MIT

There was an issue with product attribute fixtures, that there was no possibility to use more sophisticated attributes in product fixtures (like select or datetime). I decided to create a functional PHPUnit test for this bugfix, as Behat scenario would be a little bit strange and too technical, in my opinion.

@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Feb 11, 2019
@Zales0123 Zales0123 requested a review from a team as a code owner February 11, 2019 14:34
@lchrusciel
Copy link
Member

But huge 👏 for resolving bug itself ;)

@Zales0123 Zales0123 closed this Mar 29, 2019
@Zales0123 Zales0123 deleted the product-attribute-fixtures-improvements branch March 29, 2019 14:15
@Zales0123 Zales0123 restored the product-attribute-fixtures-improvements branch March 29, 2019 15:31
@Zales0123 Zales0123 reopened this Mar 29, 2019
@pamil pamil changed the base branch from 1.3 to 1.4 June 13, 2019 03:42
@pamil
Copy link
Contributor

pamil commented Jun 13, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "product-attribute-fixtures-improvements" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil force-pushed the product-attribute-fixtures-improvements branch from 75f035c to 14c2b05 Compare June 13, 2019 03:42
@pamil pamil changed the base branch from 1.4 to master June 13, 2019 03:59
@pamil pamil force-pushed the product-attribute-fixtures-improvements branch from 485d2ea to 40a8c5d Compare June 20, 2019 10:21
@pamil pamil changed the base branch from master to 1.4 June 20, 2019 10:23
@pamil pamil force-pushed the product-attribute-fixtures-improvements branch from 28c62c3 to c4f0fc7 Compare June 20, 2019 10:23
@pamil
Copy link
Contributor

pamil commented Jun 20, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "product-attribute-fixtures-improvements" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil requested a review from lchrusciel June 24, 2019 07:39
@pamil pamil merged commit e58c2b0 into Sylius:1.4 Jun 24, 2019
@pamil
Copy link
Contributor

pamil commented Jun 24, 2019

Thank you, Mateusz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants