Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sylius demo link #10185

Merged
merged 1 commit into from Feb 21, 2019
Merged

Add Sylius demo link #10185

merged 1 commit into from Feb 21, 2019

Conversation

kulczy
Copy link
Member

@kulczy kulczy commented Feb 20, 2019

Q A
Branch? 1.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

zrzut ekranu 2019-02-20 o 11 44 28

@kulczy kulczy requested a review from a team as a code owner February 20, 2019 10:51
@Zales0123 Zales0123 added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Feb 20, 2019
pamil
pamil approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased to 1.3 before merge.

@pamil pamil changed the base branch from 1.2 to 1.3 February 21, 2019 11:38
@pamil
Copy link
Contributor

pamil commented Feb 21, 2019

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "1.2-docs" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 merged commit cbc508d into Sylius:1.3 Feb 21, 2019
@Zales0123
Copy link
Member

Thank you, Szymon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kulczy @pamil @Zales0123