Make image uploader easier to customize #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Enhancement
Zales0123
force-pushed
the
make-image-uploader-easier-to-customize
branch
from
ce02ba2
to
2e6cab7
Compare
Zales0123
force-pushed
the
make-image-uploader-easier-to-customize
branch
from
2e6cab7
to
0663bed
Compare
pamil
suggested changes
Jun 25, 2019
pamil
force-pushed
the
make-image-uploader-easier-to-customize
branch
from
f697e7f
to
04e2cad
Compare
pamil
approved these changes
Aug 1, 2019
|
Thank you, Mateusz! 🎉 |
|
And Kamil! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It always annoyed me, that if you want to change anything in the images upload process (for example keep the file name, as it's done in our Behats) you need to override the whole, big service. With this change, a path generation logic has been extracted - I believe it provides much better DX right now (and fulfills SOLID principles as well) :)