[Admin] Index of payments #10472
Merged
[Admin] Index of payments #10472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
reviewed
Jun 26, 2019
| @@ -104,6 +104,12 @@ | |||
| <argument type="service" id="sylius.behat.shared_security" /> | |||
| </service> | |||
|
|
|||
| <service id="sylius.behat.context.ui.admin.managing_payments" class="Sylius\Behat\Context\Ui\Admin\ManagingPaymentsContext"> | |||
There was a problem hiding this comment.
Suggested change
| <service id="sylius.behat.context.ui.admin.managing_payments" class="Sylius\Behat\Context\Ui\Admin\ManagingPaymentsContext"> | |
| <service id="Sylius\Behat\Context\Ui\Admin\ManagingPaymentsContex" > |
?
There was a problem hiding this comment.
convention in file src/Sylius/Behat/Resources/config/services/contexts/ui.xml is made lowercase and using id and class separately
lchrusciel
reviewed
Jun 26, 2019
src/Sylius/Bundle/AdminBundle/Resources/config/grids/payment.yml
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/managing_of_payment_status.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/managing_of_payment_status.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/managing_of_payment_status.feature
Outdated
Show resolved
Hide resolved
CoderMaggie
reviewed
Jun 26, 2019
features/payment/managing_payments/managing_of_payment_status.feature
Outdated
Show resolved
Hide resolved
CoderMaggie
requested changes
Jun 26, 2019
features/payment/managing_payments/accessing_payments_order_from_payment_index.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/filtering_payments_by_state.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/filtering_payments_by_state.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/managing_of_payment_status.feature
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
browse-payment-on-list
branch
2 times, most recently
from
d85aec0
to
5464b99
Compare
GSadee
requested changes
Jun 27, 2019
Tomanhez
force-pushed
the
browse-payment-on-list
branch
from
5464b99
to
40eeefd
Compare
GSadee
approved these changes
Jun 27, 2019
features/payment/managing_payments/filtering_payments_by_state.feature
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
browse-payment-on-list
branch
from
40eeefd
to
0cc14e5
Compare
lchrusciel
reviewed
Jun 27, 2019
| And the store has "UPS" shipping method with "$10.00" fee | ||
| And the store has a product "Apple" | ||
| And the store has a product "Banana" | ||
| And the store allows paying with "Cash on Delivery" |
There was a problem hiding this comment.
I'm wondering if some default payment and shipment methods shouldn't be a part of Given the store operates on a single channel in "United States", but it is a topic for separate conversation and/or pr
features/payment/managing_payments/filtering_payments_by_state.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/grids/payment.yml
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
browse-payment-on-list
branch
2 times, most recently
from
b195215
to
05aa18a
Compare
Tomanhez
force-pushed
the
browse-payment-on-list
branch
from
05aa18a
to
a24e225
Compare
lchrusciel
approved these changes
Jun 27, 2019
src/Sylius/Bundle/AdminBundle/Resources/config/grids/payment.yml
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Jun 28, 2019
features/payment/managing_payments/accessing_payments_order_from_payment_index.feature
Outdated
Show resolved
Hide resolved
CoderMaggie
reviewed
Jun 28, 2019
features/payment/managing_payments/accessing_payments_order_from_payment_index.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/accessing_payments_order_from_payment_index.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/filtering_payments_by_state.feature
Outdated
Show resolved
Hide resolved
features/payment/managing_payments/filtering_payments_by_state.feature
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
browse-payment-on-list
branch
from
14db8cc
to
60885a9
Compare
CoderMaggie
approved these changes
Jun 28, 2019
| And I am logged in as an administrator | ||
|
|
||
| @ui | ||
| Scenario: Filtering payments by a chosen state "New" |
There was a problem hiding this comment.
These scenarios should have titles like:
Suggested change
| Scenario: Filtering payments by a chosen state "New" | |
| Scenario: Filtering payments in state "New" |
|
Thank you, Tomasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View IndexPage
All filters:
Success after push Completed button
After filtered and don't find existent state
