Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin]Admin choose channel in product show page #10483

Merged
merged 4 commits into from
Jul 4, 2019
Merged

[Admin]Admin choose channel in product show page #10483

merged 4 commits into from
Jul 4, 2019

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Jul 1, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Before clicking:
Screenshot 2019-07-01 at 10 29 19

After clicking in several channels:
Screenshot 2019-07-01 at 10 29 51

One Channel
Screenshot 2019-07-03 at 13 42 41

All channels are disabled in product
Screenshot 2019-07-04 at 10 01 31

@Tomanhez Tomanhez requested a review from a team as a code owner July 1, 2019 09:26
@Zales0123 Zales0123 added the Feature New feature proposals. label Jul 1, 2019
GSadee
GSadee requested changes Jul 1, 2019
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a screenshot for case when we have only one channel configured?

features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Setup/ChannelContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ProductShowPageContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ProductShowPageContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Admin/Product/ShowPage.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Admin/Product/ShowPage.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/Product/Show/_header.html.twig Show resolved Hide resolved
Zales0123
Zales0123 reviewed Jul 1, 2019
View reviewed changes
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ProductShowPageContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Admin/Product/ShowPage.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Admin/Product/ShowPage.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Page/Admin/Product/ShowPageInterface.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/Product/Show/_header.html.twig Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the admin-choose-channel-in-product branch 3 times, most recently from ff39c94 to e682024 Compare July 1, 2019 12:07
@Tomanhez Tomanhez force-pushed the admin-choose-channel-in-product branch from e682024 to 8db9372 Compare July 2, 2019 05:40
@Tomanhez Tomanhez force-pushed the admin-choose-channel-in-product branch from 8db9372 to 7ae8f96 Compare July 2, 2019 06:09
CoderMaggie
CoderMaggie reviewed Jul 2, 2019
View reviewed changes
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
features/product/viewing_product_in_admin_panel/viewing_product_for_particular_channel.feature Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the admin-choose-channel-in-product branch 3 times, most recently from c958bb0 to 83fa8b9 Compare July 3, 2019 10:06
@Tomanhez Tomanhez changed the title [Admin]Admin choose channel in product show page [WIP][Admin]Admin choose channel in product show page Jul 3, 2019
@Tomanhez Tomanhez force-pushed the admin-choose-channel-in-product branch from 83fa8b9 to 507e221 Compare July 3, 2019 12:35
@Tomanhez Tomanhez changed the title [WIP][Admin]Admin choose channel in product show page [Admin]Admin choose channel in product show page Jul 3, 2019
@Tomanhez Tomanhez force-pushed the admin-choose-channel-in-product branch from 507e221 to 24dea3d Compare July 4, 2019 06:10
@Tomanhez Tomanhez force-pushed the admin-choose-channel-in-product branch from 24dea3d to 71791c9 Compare July 4, 2019 08:04
lchrusciel
lchrusciel approved these changes Jul 4, 2019
View reviewed changes
src/Sylius/Behat/Context/Setup/ChannelContext.php
@@ -103,12 +103,15 @@ public function storeOperatesOnASingleChannel($currencyCode = null)
* @Given /^the store(?:| also) operates on (?:a|another) channel named "([^"]+)"$/
* @Given /^the store(?:| also) operates on (?:a|another) channel named "([^"]+)" in "([^"]+)" currency$/
* @Given the store operates on a channel identified by :code code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to code, it is soooo much not true. Can you open an issue with it

src/Sylius/Behat/Context/Setup/ChannelContext.php
{
$channelCode = StringInflector::nameToLowercaseCode($channelName);
$defaultData = $this->defaultChannelFactory->create($channelCode, $channelName, $currencyCode);

($hostname !== null) ? $defaultData['channel'] = $defaultData['channel']->setHostname($hostname) : null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
($hostname !== null) ? $defaultData['channel'] = $defaultData['channel']->setHostname($hostname) : null;
$defaultData['channel']->setHostname($hostname);

@lchrusciel lchrusciel merged commit c125ab0 into Sylius:master Jul 4, 2019
@lchrusciel
Copy link
Member

Thank you, Tomasz! 🥇

@Tomanhez Tomanhez mentioned this pull request Jul 4, 2019
Merged
pamil added a commit that referenced this pull request Jul 4, 2019
@pamil
bug #10497 Minor Fixes - Admin choose channel in product show page (T…
221b67a 
…omanhez)

This PR was merged into the 1.5-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| License         | MIT


Fixes : #10483


Commits
-------

80ea6f2 Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee requested changes

@Zales0123 Zales0123 Zales0123 left review comments

@CoderMaggie CoderMaggie CoderMaggie left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Tomanhez @lchrusciel @GSadee @Zales0123 @CoderMaggie