Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked router dependency as deprecated in admin ImpersonateUserController #10488

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Marked router dependency as deprecated in admin ImpersonateUserController #10488

merged 1 commit into from
Jul 18, 2019

Conversation

SebLours
Copy link
Contributor

@SebLours SebLours commented Jul 2, 2019

Q A
Branch? 1.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

@SebLours SebLours requested a review from a team as a code owner July 2, 2019 07:05
lchrusciel
lchrusciel reviewed Jul 18, 2019
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only mark it as deprecated and allow null value. Otherwise, it is BC break :(

@SebLours SebLours changed the title Removed unused router dependency from ImpersonateUserController Marked router dependency as deprecated in admin ImpersonateUserController Jul 18, 2019
@SebLours
Copy link
Contributor Author

Oops ...!
I fix it as a deprecation.

@lchrusciel lchrusciel merged commit 1c687e5 into Sylius:1.4 Jul 18, 2019
@lchrusciel
Copy link
Member

Thank you, Sébastien! 🥇

@SebLours SebLours deleted the fix-admin-impersonate-user branch July 18, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SebLours @lchrusciel