Make it possible to have no shipping methods for Order fixtures #10489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiMESPLiNTER
changed the title
lchrusciel
approved these changes
Jul 2, 2019
|
|
||
| for ($i = 0; $i < $numberOfItems; ++$i) { | ||
| /** @var OrderItemInterface $item */ | ||
| $item = $this->orderItemFactory->createNew(); | ||
|
|
||
| $product = $this->faker->randomElement($products); | ||
| $variant = $this->faker->randomElement($product->getVariants()->toArray()); | ||
| $variant->setShippingRequired($shippingMethodsAvailable); |
There was a problem hiding this comment.
Later, we should improve these fixtures and allow for configuration from yaml file
There was a problem hiding this comment.
Should I improve the issue description and we keep it open or should I create a new issue for making it configurable?
|
And welcome to our contributors :) |
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
Zales0123
added
the
Enhancement
|
Thank you, Pascal! 🎉 |
GSadee
added a commit
that referenced
this pull request
Jul 9, 2019
…rder fixtures" (lchrusciel) This PR was merged into the 1.4 branch. Discussion ---------- Reverts #10489 Ref. 608546b#r34204877 Commits ------- ed1f72f Revert "Make it possible to have no shipping methods for Order fixtures"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's not possible to have fixture suites with no shipping methods (a.k.a. virtual shipping only). This PR makes it possible.