Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Improve breadcrumbs (especially for ProductVariants and PromotionCoupons) #10512

Merged
merged 3 commits into from
Aug 5, 2019

Conversation

CoderMaggie
Copy link
Member

@CoderMaggie CoderMaggie commented Jul 9, 2019

Q A
Branch? 1.4
Bug fix? no
New feature? rather an improvement
BC breaks? no
Deprecations? no
Related tickets triggered by #10509 😄
License MIT

The clue is to use entities names instead of codes, wherever it is possible. especially in entities that are under other entities like coupons or variants.

Product variant edit:
Before:
image

After:
image

Without the variant name:
image

Channels edit:
Before:
image

After:
image

And while trying to unsuccessfully remove the name:
image

After (translation of names to Admin locale)
image
image
image

@CoderMaggie CoderMaggie added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). UX Issues and PRs aimed at improving User eXperience. Admin AdminBundle related issues and PRs. labels Jul 9, 2019
@CoderMaggie CoderMaggie requested a review from a team as a code owner July 9, 2019 07:21
@pjedrzejewski
Copy link
Member

IIRC the reason to use codes was to avoid issues when editing. Because if you try to change name to empty, the breeadcrumb will take the data from the entity, which will have empty value bound by the forms logic... :)

@vvasiloi
Copy link
Contributor

IIRC the reason to use codes was to avoid issues when editing. Because if you try to change name to empty, the breeadcrumb will take the data from the entity, which will have empty value bound by the forms logic... :)

@pjedrzejewski resource.name|default(resource.code)? 😄

@CoderMaggie
Copy link
Member Author

The editing issue is very minor compared to the logic of displaying codes (that are an internal property used for processing things), while we have names (that are designed to be displayed everywhere). :)

I guess the weirdy forms' logic is not an issue that should be solved by displaying our immutable codes instead of names.

Although I will use the tip from @vvasiloi for now, thanks 💪

@CoderMaggie CoderMaggie changed the title [Admin] Improve breadcrumbs for Products, ProductVariants, Promotions and PromotionCoupons [Admin] Improve breadcrumbs (especially for ProductVariants and PromotionCoupons) Jul 16, 2019
@CoderMaggie CoderMaggie requested a review from GSadee July 16, 2019 12:34
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide some "before" and "after" screenshots? 🐎

@Zales0123
Copy link
Member

@CoderMaggie rebase should fix the build :)

@GSadee GSadee merged commit 3f34a57 into Sylius:1.4 Aug 5, 2019
@GSadee
Copy link
Member

GSadee commented Aug 5, 2019

Thank you, Magdalena! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants