[Grid] Allow not to pass "apply_transition" button class #10517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
the
Enhancement
Zales0123
force-pushed
the
allow-not-to-pass-apply-transition-button-class
branch
from
ea452ec
to
8f92568
Compare
pamil
reviewed
Jul 10, 2019
src/Sylius/Bundle/UiBundle/Resources/views/Grid/Action/applyTransition.html.twig
Outdated
Show resolved
Hide resolved
Zales0123
force-pushed
the
allow-not-to-pass-apply-transition-button-class
branch
from
8f92568
to
15752a6
Compare
lchrusciel
reviewed
Jul 18, 2019
| @@ -2,6 +2,6 @@ | |||
| <form action="{{ path(options.link.route, options.link.parameters) }}" method="post"> | |||
| <input type="hidden" name="_csrf_token" value="{{ csrf_token(data.id) }}"> | |||
| <input type="hidden" name="_method" value="PUT"> | |||
| <button class="ui loadable {{ options.class }} labeled icon button" type="submit"><i class="{{ action.icon }} icon"></i> {{ action.label|trans }}</button> | |||
| <button class="ui loadable {{ options.class|default }} labeled icon button" type="submit"><i class="{{ action.icon }} icon"></i> {{ action.label|trans }}</button> | |||
There was a problem hiding this comment.
Can we also remove icon constraint?
Suggested change
| <button class="ui loadable {{ options.class|default }} labeled icon button" type="submit"><i class="{{ action.icon }} icon"></i> {{ action.label|trans }}</button> | |
| <button class="ui loadable {{ options.class|default }} labeled icon button" type="submit"><i class="{{ action.icon|default }} icon"></i> {{ action.label|trans }}</button> |
|
Thanks, Mateusz! 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suppose it should not be required. It's quite weird to get an exception if you do not specify the color of the button 馃悞