Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Unify order link in Orders, Payments, Shipments #10518

Merged
merged 2 commits into from
Jul 12, 2019
Merged

[Admin] Unify order link in Orders, Payments, Shipments #10518

merged 2 commits into from
Jul 12, 2019

Conversation

Tomanhez
Copy link
Contributor

@Tomanhez Tomanhez commented Jul 10, 2019 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Add link in orders
Screenshot 2019-07-12 at 07 38 21

Add link in payments and delete Show button
Screenshot 2019-07-12 at 07 39 12

Add link in shipment and delete Show button
Screenshot 2019-07-12 at 07 39 25

@Tomanhez Tomanhez requested a review from a team as a code owner July 10, 2019 12:54
@CoderMaggie CoderMaggie added Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience. labels Jul 11, 2019
@Tomanhez Tomanhez force-pushed the unify-order-link branch 3 times, most recently from cb01278 to 6b2c781 Compare July 11, 2019 08:11
GSadee
GSadee reviewed Jul 12, 2019
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it clear and consistent, change also the column title for the order number from Number to Order on payment and shipment indexes

@GSadee GSadee merged commit 525f42d into Sylius:master Jul 12, 2019
@GSadee
Copy link
Member

GSadee commented Jul 12, 2019

Thanks, Tomasz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoderMaggie CoderMaggie CoderMaggie left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tomanhez @GSadee @CoderMaggie