Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve filters UI #10531

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Improve filters UI #10531

merged 1 commit into from
Jul 18, 2019

Conversation

kulczy
Copy link
Member

@kulczy kulczy commented Jul 17, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

22

11

@kulczy kulczy requested a review from a team as a code owner July 17, 2019 12:21
@CoderMaggie CoderMaggie added Admin AdminBundle related issues and PRs. RFC Discussions about potential changes or new features. UX Issues and PRs aimed at improving User eXperience. labels Jul 17, 2019
@Roshyo
Copy link
Contributor

Roshyo commented Jul 17, 2019 •
edited
Loading

IMO, filters should be set in the <th> of each attribute if possible, and in a separate block if they deal with multiple/no specific attribute.

That's what any other CMS do and it feels very intuitive.

The matching can be done by name (replacing '.' by '_') or with a specific configuration line.

And for the filter block itself. The global width of number inputs is way too large.

@vvasiloi
Copy link
Contributor

In the first screenshot the number value field has an icon, what's that? Should it be for the customer input?

@kulczy
Copy link
Member Author

kulczy commented Jul 17, 2019 •
edited
Loading

@vvasiloi my bad, it's just a chrome addon :D

@vcraescu
Copy link
Contributor

@kulczy it's ok! 😁

@GSadee GSadee merged commit eab61a3 into Sylius:master Jul 18, 2019
@GSadee
Copy link
Member

GSadee commented Jul 18, 2019

Thanks, Szymon! 🎉

@kulczy kulczy deleted the filters-ui-date branch April 4, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. RFC Discussions about potential changes or new features. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kulczy @Roshyo @vvasiloi @vcraescu @GSadee @CoderMaggie