Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Order] Change OrderItemController methods to protected #10552

Merged
merged 1 commit into from
Jul 26, 2019
Merged

[Order] Change OrderItemController methods to protected #10552

merged 1 commit into from
Jul 26, 2019

Conversation

Zales0123
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Even though I love Composition over inheritance principle, this controller is already poorly written and, I believe, we should make its customization as painless as possible 🔪 🤕

@Zales0123 Zales0123 added the DX Issues and PRs aimed at improving Developer eXperience. label Jul 25, 2019
@Zales0123 Zales0123 requested a review from a team as a code owner July 25, 2019 12:50
@pamil pamil merged commit 7ec3375 into Sylius:master Jul 26, 2019
@pamil
Copy link
Contributor

pamil commented Jul 26, 2019

Thanks, Mateusz! 🥇

@Zales0123 Zales0123 deleted the make-order-item-controller-more-extendable branch July 26, 2019 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zales0123 @pamil