Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags are not languages #10553

Merged
merged 5 commits into from
Jul 26, 2019
Merged

Flags are not languages #10553

merged 5 commits into from
Jul 26, 2019

Conversation

vvasiloi
Copy link
Contributor

@vvasiloi vvasiloi commented Jul 25, 2019 •
edited
Loading

Q A
Branch? 1.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #10416, #9479
License MIT

NOTE: There is a commit per file because the PR was crafted entirely on GitHub.

@vvasiloi vvasiloi requested a review from a team as a code owner July 25, 2019 15:26
@vvasiloi vvasiloi mentioned this pull request Jul 25, 2019
Closed
@pamil pamil added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Jul 26, 2019
@pamil pamil merged commit 338de41 into Sylius:1.4 Jul 26, 2019
@pamil
Copy link
Contributor

pamil commented Jul 26, 2019

Thanks, Victor! 🥇

@pamil pamil mentioned this pull request Jul 26, 2019
Closed
@vvasiloi vvasiloi deleted the flags_are_not_languages branch July 26, 2019 11:08
@vvasiloi vvasiloi mentioned this pull request Aug 31, 2020
Open
@vvasiloi vvasiloi mentioned this pull request Jan 18, 2022
Closed
@vvasiloi vvasiloi mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vvasiloi @pamil