[Shop] Promotion integrity checker fix #10603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
changed the title
|
Wow ! Many thanks to you too making this fix ! |
lchrusciel
changed the title
lchrusciel
force-pushed
the
promotion-integrity-checker
branch
from
5e41ced
to
bb83ba7
Compare
vvasiloi
reviewed
Aug 21, 2019
src/Sylius/Bundle/ShopBundle/EventListener/OrderPromotionIntegrityChecker.php
Outdated
Show resolved
Hide resolved
vvasiloi
reviewed
Aug 21, 2019
src/Sylius/Bundle/ShopBundle/EventListener/OrderPromotionIntegrityChecker.php
Outdated
Show resolved
Hide resolved
vvasiloi
reviewed
Aug 21, 2019
src/Sylius/Bundle/ShopBundle/EventListener/OrderPromotionIntegrityChecker.php
Outdated
Show resolved
Hide resolved
|
@lchrusciel good solution! 🎉 Left a few comments, maybe you find something worth considering. |
lchrusciel
force-pushed
the
promotion-integrity-checker
branch
from
bb83ba7
to
f53fedd
Compare
GSadee
reviewed
Aug 22, 2019
features/checkout/order_promotion/order_promotion_integrity_validation.feature
Outdated
Show resolved
Hide resolved
features/checkout/order_promotion/order_promotion_integrity_validation.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutCompleteContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/EventListener/OrderPromotionIntegrityChecker.php
Outdated
Show resolved
Hide resolved
lchrusciel
force-pushed
the
promotion-integrity-checker
branch
2 times, most recently
from
de534dd
to
c55aa86
Compare
lchrusciel
force-pushed
the
promotion-integrity-checker
branch
from
c55aa86
to
e73a517
Compare
GSadee
approved these changes
Aug 22, 2019
Tomanhez
approved these changes
Aug 22, 2019
pamil
approved these changes
Aug 22, 2019
|
Thank you, Łukasz! 🥇 |
This was referenced Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big thanks to @vvasiloi, @Prometee, and @oallain for providing detailed bug report, behat scenario and possible issues!
It appears that by rebound I fixed #9940 as well. Described in 5e41ced