Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PayumBundle] Use Payment amount in Payum gateways actions #10613

Merged
merged 2 commits into from
Aug 23, 2019
Merged

[PayumBundle] Use Payment amount in Payum gateways actions #10613

merged 2 commits into from
Aug 23, 2019

Conversation

Zales0123
Copy link
Member

@Zales0123 Zales0123 commented Aug 23, 2019 •
edited
Loading

Q A
Branch? 1.5
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets replaces #10574, fixes #8958
License MIT

Replaces the previous fix, with fixed spec. Thank you @Leobaillard for your work! 馃帀 馃弴

@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Aug 23, 2019
@Zales0123 Zales0123 requested a review from a team as a code owner August 23, 2019 11:14
@Zales0123 Zales0123 mentioned this pull request Aug 23, 2019
Closed
@Zales0123 Zales0123 changed the base branch from master to 1.4 August 23, 2019 11:22
@Zales0123 Zales0123 changed the base branch from 1.4 to master August 23, 2019 11:24
@Zales0123 Zales0123 force-pushed the use-payment-amount-in-payum-actions branch from c0ba81d to e4e50ce Compare August 23, 2019 11:28
@Zales0123 Zales0123 changed the base branch from master to 1.5 August 23, 2019 11:28
@pamil pamil merged commit 583cd07 into Sylius:1.5 Aug 23, 2019
@pamil
Copy link
Contributor

pamil commented Aug 23, 2019 •
edited
Loading

Thanks, Mateusz and Leopold! 馃帀

@pamil pamil mentioned this pull request Aug 23, 2019
Closed
@Zales0123 Zales0123 deleted the use-payment-amount-in-payum-actions branch August 23, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zales0123 @pamil @lchrusciel @AdamKasp