Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixtures fixes #10716

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Minor fixtures fixes #10716

merged 1 commit into from
Oct 2, 2019

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch?
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? n
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner September 28, 2019 10:03
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it solve some of order fixtures problems like #10719?

@AdamKasp
Copy link
Contributor Author

AdamKasp commented Oct 1, 2019

Will it solve some of order fixtures problems like #10719?

No, it fixed the only problem with missing fixture data :(

@lchrusciel lchrusciel changed the base branch from master to 1.6 October 1, 2019 09:12
@lchrusciel lchrusciel changed the base branch from 1.6 to master October 1, 2019 09:12
@lchrusciel
Copy link
Member

As it is bugfix, we should add it to 1.6

@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "minor-fixture-fixes" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel lchrusciel changed the base branch from master to 1.6 October 1, 2019 09:13
@GSadee GSadee merged commit 1e10241 into Sylius:1.6 Oct 2, 2019
@GSadee
Copy link
Member

GSadee commented Oct 2, 2019

Thank you, Adam! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants